Docs: fix markup for importlib.machinery.NamespaceLoader
#112479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
skip issue
skip news
needs backport to 3.11
Currently:[I cannot link to it because the markup is wrong, so Sphinx is not adding an anchor] Screenshot
With this PR:Docs preview: https://cpython-previews--112479.org.readthedocs.build/en/112479/library/importlib.html#importlib.machinery.NamespaceLoader Screenshot
|
AlexWaygood
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2023
…112479) (cherry picked from commit 2e632fa) Co-authored-by: Alex Waygood <[email protected]>
|
GH-112481 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2023
…112479) (cherry picked from commit 2e632fa) Co-authored-by: Alex Waygood <[email protected]>
|
GH-112482 is a backport of this pull request to the 3.11 branch. |
AlexWaygood
added a commit
that referenced
this pull request
Nov 28, 2023
…-112479) (#112482) Docs: fix markup for `importlib.machinery.NamespaceLoader` (GH-112479) (cherry picked from commit 2e632fa) Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
added a commit
that referenced
this pull request
Nov 28, 2023
…-112479) (#112481) Docs: fix markup for `importlib.machinery.NamespaceLoader` (GH-112479) (cherry picked from commit 2e632fa) Co-authored-by: Alex Waygood <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markup for this class is incorrect, leading it to be rendered incorrectly by Sphinx, and meaning that there's no anchor on the HTML webpage that you can link to.
📚 Documentation preview 📚: https://cpython-previews--112479.org.readthedocs.build/