gh-106550: Fix sign conversion in pycore_code.h #112613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed.
serhiy-storchaka
approved these changes
Dec 4, 2023
| @@ -473,12 +475,12 @@ adaptive_counter_cooldown(void) { | |||
|
|
|||
| static inline uint16_t | |||
| adaptive_counter_backoff(uint16_t counter) { | |||
| unsigned int backoff = counter & ((1<<ADAPTIVE_BACKOFF_BITS)-1); | |||
| uint16_t backoff = counter & ((1 << ADAPTIVE_BACKOFF_BITS) - 1); | |||
There was a problem hiding this comment.
Is there difference between 1 << ADAPTIVE_BACKOFF_BITS and 1u << ADAPTIVE_BACKOFF_BITS?
There was a problem hiding this comment.
I hesitated to replace 1 with 1U. With proposed code, there is no warning. With 1U I got additional warnings 🤷🏻♂️ Maybe because "unsigned int" is larger than uint16_t. I don't know rules of implicit cast in C.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-112696 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2023
Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed. (cherry picked from commit a74902a) Co-authored-by: Victor Stinner <[email protected]>
|
Merged, thanks for the review Serhiy. |
vstinner
added a commit
that referenced
this pull request
Dec 4, 2023
…112696) gh-106550: Fix sign conversion in pycore_code.h (GH-112613) Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed. (cherry picked from commit a74902a) Co-authored-by: Victor Stinner <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sign conversion in pycore_code.h: use unsigned integers and cast explicitly when needed.