Skip to content

[pprint]: Add docstring about PrettyPrinter.underscore_numbers parameter #112963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

KrySeyt
Copy link
Contributor

@KrySeyt KrySeyt commented Dec 11, 2023

pprint.PrettyPrinter.init param underscore_numbers description added in method docstring.

Should I create NEWS entry?

@ghost
Copy link

ghost commented Dec 11, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@KrySeyt KrySeyt force-pushed the pprint_small_docstring_update branch from 7778d4a to cd3d6fe Compare December 11, 2023 14:56
@bedevere-app

This comment was marked as duplicate.

@bedevere-app

This comment was marked as duplicate.

@Eclips4 Eclips4 changed the title pprint.PrettyPrinter.__init__ param description Add docstring about PrettyPrinter.underscore_numbers parameter Dec 12, 2023
@Eclips4 Eclips4 changed the title Add docstring about PrettyPrinter.underscore_numbers parameter [pprint]: Add docstring about PrettyPrinter.underscore_numbers parameter Dec 12, 2023
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps we can improve the wording, but I'm not a native English speaker 😢.
cc @AlexWaygood

fix typo

Co-authored-by: Kirill Podoprigora <[email protected]>
@AlexWaygood AlexWaygood self-requested a review December 12, 2023 16:25
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@AlexWaygood AlexWaygood merged commit 2a3c37c into python:main Dec 13, 2023
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 13, 2023
@miss-islington-app
Copy link

Thanks @KrySeyt for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @KrySeyt for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 13, 2023

GH-113052 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2023
…meter (pythonGH-112963)

(cherry picked from commit 2a3c37c)

Co-authored-by: Sequew <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2023
…meter (pythonGH-112963)

(cherry picked from commit 2a3c37c)

Co-authored-by: Sequew <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 13, 2023

GH-113053 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 13, 2023
AlexWaygood pushed a commit that referenced this pull request Dec 13, 2023
…s` parameter (GH-112963) (#113053)

[pprint]: Add docstring about `PrettyPrinter.underscore_numbers` parameter (GH-112963)
(cherry picked from commit 2a3c37c)

Co-authored-by: Sequew <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Dec 13, 2023
…s` parameter (GH-112963) (#113052)

[pprint]: Add docstring about `PrettyPrinter.underscore_numbers` parameter (GH-112963)
(cherry picked from commit 2a3c37c)

Co-authored-by: Sequew <[email protected]>
Co-authored-by: Kirill Podoprigora <[email protected]>
@Eclips4
Copy link
Member

Eclips4 commented Dec 13, 2023

Thanks @KrySeyt for the PR!

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants