-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-87264: Convert tarinfo type to stat type #113230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-87264: Convert tarinfo type to stat type #113230
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging this for core dev discussion. Attribution should be shared with #29974
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Hi @alphavector. I flagged this for core dev discussion since a similar PR was opened earlier on this subject: #29974 I would like to make sure that the first PR gets attribution/thanks for the change as well as you. |
This PR appears to be a copy/paste of the other, with only a slight modification of the test. Since the changes are fairly simple, and @val-shkolnikov claims they signed the CLA with a different email, and @alphavector was kind enough to push for this, I'm happy to accept it and merge (with attribution for both). |
@ethanfurman Thanks for doing so. I will go ahead and approve and let you handle the merge/attribution. 😄 |
Attribution can be added by including "Co-Authored-by: " at the end of commit message when merging the PR. |
Yes, I had no goal to downplay @val-shkolnikov's contribution, my involvement is minimal, the PR was all set and I gave it a little push |
Thanks @alphavector. I appreciate the effort. I hope to see more contributions from you in the future. ☀️ |
Co-authored-by: val-shkolnikov <[email protected]>
Co-authored-by: val-shkolnikov <[email protected]>
Co-authored-by: val-shkolnikov <[email protected]>
This PR seems to be a bit stuck, this is an attempt to resuscitate it