Skip to content

TaskGroup: Explicitly None check for propagated cancellation error #114708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matan1008
Copy link
Contributor

The issue is trivial IMHO, if you think otherwise I will submit an issue.

@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@gvanrossum
Copy link
Member

How did you discover this? Since it's always either None or a CancelledError, which doesn't override __eq__ or __bool__, the original code should be safe, right?

@matan1008
Copy link
Contributor Author

Technically (and stupidly practically) someone might raise an exception from the following kind inside the TaskGroup code block:

class StrangeException(asyncio.CancelledError):
    def __bool__(self):
        return False

Which in my humble opinion might result in unexpected behaviour

@gvanrossum gvanrossum merged commit 29952c8 into python:main Jan 29, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants