Update venv activate.bat to escape custom PROMPT variables on Windows #114885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vsajip
reviewed
Feb 2, 2024
vsajip
approved these changes
Feb 2, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should the
PROMPTenvironment variable contain special characters already (such as^), this ensures the special characters are properly escaped when the prompt is prefixed in the venv activation script.This also solves for special characters such as
>or<, but>and<are more so a user error—they should instead be set as$Gand$Lin thePROMPTenvironment variable, in which case the activation script today will work fine.^does not have such an escape in thePROMPTenvironment variable and thus should be dealt with properly here.More information about the
PROMPTenvironment variable and escapes here: https://ss64.com/nt/prompt.html.The change is small enough that I’ve decided to forego an issue number or NEWS update.