Skip to content

bpo-35727: Use exit code 0 on sys.exit() in multiprocessing.Process. #11538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2020
Merged

bpo-35727: Use exit code 0 on sys.exit() in multiprocessing.Process. #11538

merged 3 commits into from
Feb 21, 2020

Conversation

chrahunt
Copy link
Contributor

@chrahunt chrahunt commented Jan 12, 2019 •
edited
Loading

eamanu
eamanu reviewed Jan 13, 2019
View reviewed changes
eamanu
eamanu approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will wait for review from someone else. Thanks!

asottile
asottile reviewed Jan 16, 2019
View reviewed changes
@csabella csabella requested a review from applio May 13, 2019 12:59
@applio
Copy link
Member

applio commented Sep 13, 2019

Added a question in issue35727 on bpo.
At a minimum, this patch will need to be updated to reflect more recent changes (mostly from June, I think) but we should discuss more on bpo.

@chrahunt
Copy link
Contributor Author

@applio, thanks for taking a look! I rebased on master (it didn't require any changes I could see) and commented on your points on bpo.

pitrou
pitrou approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question though

@pitrou pitrou merged commit c2ac4cf into python:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

@asottile asottile asottile left review comments

@eamanu eamanu eamanu approved these changes

@applio applio Awaiting requested review from applio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chrahunt @applio @pitrou @asottile @eamanu @the-knights-who-say-ni @bedevere-bot