-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-35749: Don't log exception if event loop wakeup pipe is full #11577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pass | ||
|
||
def _read_from_self(self): | ||
wakeup = False | ||
while True: | ||
try: | ||
data = self._ssock.recv(4096) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use sock.recv_into()
here. Not sure if it worth to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" bpo-35749: Don't log exception if event loop wakeup pipe is full #11577" title is inaccurate. Your change just completely rewrite how asyncio handles signals.
Ignoring logs when the pipe is full is a weak rationale to rewrite signal handling. Please dig into the history to see why asyncio is written like that. I recall vaguely that there were complex race conditions on FreeBSD.
I'm not against "experimenting" new way to handle signals, but it would need a better rationale.
When you're done making the requested changes, leave the comment: |
I'll change the title and changelog text if we decide to land the change. Let' me explain the motivation better:
|
https://bugs.python.org/issue35749