Skip to content

asyncio: Use dict instead of OrderedDict #11710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

asyncio: Use dict instead of OrderedDict #11710

merged 1 commit into from
Feb 5, 2019

Conversation

methane
Copy link
Member

@methane methane commented Jan 31, 2019

No description provided.

@methane methane requested review from 1st1 and asvetlov as code owners January 31, 2019 07:33
eamanu
eamanu approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1st1
1st1 reviewed Jan 31, 2019
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the comment. Is the 'collections' module still used?

@methane
Copy link
Member Author

methane commented Jan 31, 2019

Yes, for deque.

@methane methane merged commit f345170 into python:master Feb 5, 2019
@methane methane deleted the asyncio-remove-ordereddict branch February 5, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 left review comments

@eamanu eamanu eamanu approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @1st1 @eamanu @the-knights-who-say-ni @bedevere-bot