[WIP] bpo-1294959: Better support for systems with /usr/lib64 #11755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is based on #3698 rebased on top of master and the NEWS entries tidied up a bit. I haven't tested it yet as of recently thus the WIP in the title. |
merwok
reviewed
Feb 4, 2019
| def getdocloc(self, object, | ||
| basedir=os.path.join(sys.base_exec_prefix, "lib", | ||
| "python%d.%d" % sys.version_info[:2])): | ||
| def getdocloc(self, object, basedir=sysconfig.get_path('stdlib')): |
There was a problem hiding this comment.
This looks like a good fix regardless of the lib/lib64/debian-triplet question!
Maybe open a distinct ticket and cherry-pick this change in a PR?
There was a problem hiding this comment.
There was already https://bugs.python.org/issue21016 issue for that and I proposed a separted PR: #18476
|
@stratakis, thank you for opening this to continue the work from #3698. Please fix the merge conflicts and that will retrigger the CI builds. Thanks! |
This introduces a new configure and sysconfig variable `platsubdir`, which is the name of subdirectory of $prefix that holds platform-specific libraries. On many Linux distributions, there is separation between /usr/lib and /usr/lib64, which was causing some problems due to the way Python manages its install paths. Now, platsubdir is used to select the appropriate lib directory.
stratakis
force-pushed
the
lib64
branch
3 times, most recently
from
d2ac93a to
4c53566
Compare
|
Closing this in favor of #18381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1294959