-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-118013: Use weakrefs for the cache key in inspect._shadowed_dict
#118202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexWaygood
merged 9 commits into
python:main
from
AlexWaygood:inspect-weakref-cache-key
Apr 24, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c314217
wip
AlexWaygood e4b2989
wip
AlexWaygood 57da345
wip
AlexWaygood 4df5d08
wip
AlexWaygood fd9b22b
Merge branch 'main' into inspect-weakref-cache-key
AlexWaygood 5847027
Tests and comments
AlexWaygood 677577e
Clear the cache anyway after running `test_inspect`, for extra safety
AlexWaygood 6891c70
docs
AlexWaygood 4791b4b
Merge branch 'main' into inspect-weakref-cache-key
AlexWaygood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
Misc/NEWS.d/next/Library/2024-04-24-12-20-48.gh-issue-118013.TKn_kZ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Fix regression introduced in gh-103193 that meant that calling | ||
:func:`inspect.getattr_static` on an instance would cause a strong reference | ||
to that instance's class to persist in an internal cache in the | ||
:mod:`inspect` module. This caused unexpected memory consumption if the | ||
class was dynamically created, the class held strong references to other | ||
objects which took up a significant amount of memory, and the cache | ||
contained the sole strong reference to the class. The fix for the regression | ||
leads to a slowdown in :func:`getattr_static`, but the function should still | ||
be signficantly faster than it was in Python 3.11. Patch by Alex Waygood. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.