-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-35972: _xxsubinterpreters: Fix potential integer truncation in channel_send() #11822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since it's a private API and _xxsubinterpreters is a private module, I don't think that a NEWS entry is needed. @ericsnowcurrently: Would you mind to review this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(marking so it doesn't get merged yet)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
As noted on the tracker issue, LGTM. I have added a comment to |
If you really need 64-bit on 32-bit system, you can use int64_t. But it means that you should change _PyCrossInterpreterData.data type. |
Buildbots have detected a leak of memory blocks in this PR. I have oppened: https://bugs.python.org/issue35984 I do not have time to look into this until this night. |
https://bugs.python.org/issue35972