Skip to content

gh-118055: Updated the finder glossary entry #118278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2024

Conversation

Lincoln-developer
Copy link
Contributor

@Lincoln-developer Lincoln-developer commented Apr 25, 2024

The glossary entry predated that language reference page (2012) and importlib (2009), and that no one thought to update the glossary entry at the time. Therefore, this pull request addresses this issue by changing the Python version from 3.3 to 2.3 which PEP 302 targeted. Further by referring to the language reference and the importlib docs as better resources than the PEPs for explaining the various facets of the import system.


📚 Documentation preview 📚: https://cpython-previews--118278.org.readthedocs.build/en/118278/glossary.html#term-finder

Copy link
Contributor

@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk , I think this one is good to merge.
The workflow says "waiting to be approved" but I don't see anything wrong, do you agree?

@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 25, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericsnowcurrently How's this look?

@encukou encukou enabled auto-merge (squash) May 30, 2024 08:39
@encukou encukou merged commit db00934 into python:main May 30, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @Lincoln-developer for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 30, 2024

GH-119773 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 30, 2024

GH-119774 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label May 30, 2024
encukou pushed a commit that referenced this pull request May 30, 2024
…9774)

gh-118055: Update the finder glossary entry (GH-118278)
(cherry picked from commit db00934)

Co-authored-by: Lincoln <[email protected]>
encukou pushed a commit that referenced this pull request May 30, 2024
…9773)

gh-118055: Update the finder glossary entry (GH-118278)
(cherry picked from commit db00934)

Co-authored-by: Lincoln <[email protected]>
@Lincoln-developer
Copy link
Contributor Author

Thanks @encukou for the merge, let me pick another issue to work on

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants