Skip to content

Docs: add whatsnew for free-threading #118679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented May 6, 2024

@colesbury colesbury requested review from DinoV and hugovk May 6, 2024 23:54
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels May 6, 2024
@colesbury colesbury changed the title Docs: add whatnew for free-threading Docs: add whatsnew for free-threading May 6, 2024
Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd add a bit of motivation to balance the flashing warning signs.

Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Łukasz Langa <[email protected]>
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually I'd like to see more color about what extension modules should do to be built specially for the free-threaded build. (Not necessarily here, but maybe in a HOWTO doc or section of the Extending and Embedding docs linked from here.)

Comment on lines +1071 to +1074
* Use :func:`!sys._is_gil_enabled` to determine if the :term:`GIL` is enabled.

* Use ``sysconfig.get_config_var("Py_GIL_DISABLED")`` to identify CPython
builds configured with ``--disable-gil``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear from this why we need both APIs. I'm guessing it's because even when built with --disable-gil the GIL may be dynamically re-enabled?

@colesbury
Copy link
Contributor Author

colesbury commented May 7, 2024

The extension HOWTO and further docs updates are definitely on the list of things to do, but will probably happen sometime after beta 1.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colesbury colesbury merged commit 60bd111 into python:main May 7, 2024
@colesbury colesbury deleted the whatsnew-free-threaded branch May 7, 2024 01:48
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants