-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Docs: add whatsnew for free-threading #118679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd add a bit of motivation to balance the flashing warning signs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Łukasz Langa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually I'd like to see more color about what extension modules should do to be built specially for the free-threaded build. (Not necessarily here, but maybe in a HOWTO doc or section of the Extending and Embedding docs linked from here.)
* Use :func:`!sys._is_gil_enabled` to determine if the :term:`GIL` is enabled. | ||
|
||
* Use ``sysconfig.get_config_var("Py_GIL_DISABLED")`` to identify CPython | ||
builds configured with ``--disable-gil``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear from this why we need both APIs. I'm guessing it's because even when built with --disable-gil
the GIL may be dynamically re-enabled?
The extension HOWTO and further docs updates are definitely on the list of things to do, but will probably happen sometime after beta 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Łukasz Langa <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--118679.org.readthedocs.build/