bpo-36015: logging: handle StreamHandler representaton of stream with int name #11908
Conversation
|
This caused us quite some confusion when we started deploying 3.7 applications to Prod two weeks ago, and there were literally zero applicable results on Google for some time, until I looked it up again today and found this PR. Glad to see that it is, as we suspected, a CPython bug, and that there's a fix in the works. Thanks! |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
When debugging uwsgi logging issues with python3.7 i got this:
Traceback (most recent call last):
File "/usr/lib/python3.7/logging/__init__.py", line 269, in _after_at_fork_weak_calls
_at_fork_weak_calls('release')
File "/usr/lib/python3.7/logging/__init__.py", line 261, in _at_fork_weak_calls
method_name, "method:", err, file=sys.stderr)
File "/usr/lib/python3.7/logging/__init__.py", line 1066, in __repr__
name = name + ' '
TypeError: unsupported operand type(s) for +: 'int' and 'str'
xrmx
force-pushed
the
handlestreamwithintname
branch
from
5b9ab8e to
5a8a67a
Compare
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
|
@vsajip thanks for merging, would it be possible to add the label to have this backported to 3.7 please? |
…er name (pythonGH-11908) (cherry picked from commit ca87eeb) Co-authored-by: Riccardo Magliocchetti <[email protected]>
|
GH-13183 is a backport of this pull request to the 3.7 branch. |
…er name (GH-11908) (GH-13183) (cherry picked from commit ca87eeb) Co-authored-by: Riccardo Magliocchetti <[email protected]>
When debugging uwsgi logging issues with python3.7 i got this:
https://bugs.python.org/issue36015