bpo-36096: IDLE: Refactor class variables in colorizer #12002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
approved these changes
Feb 24, 2019
terryjreedy
approved these changes
Feb 24, 2019
| @@ -0,0 +1 @@ | |||
| Refactor class variables to instance variables in colorizer. | |||
There was a problem hiding this comment.
For the present, I will take care of the idlelib news.txt entries.
There was a problem hiding this comment.
I should have asked this earlier, but once you approve a PR, should I then merge it? Thanks.
There was a problem hiding this comment.
If I check the []Approve box for a Review, and if you agree that it is ready, and accept the responsibility of doing the merge, yes. For most IDLE issues though, I consider the followup responsibility to be shared. If you prefer me to merge, say so. If a PR is actually a joint product, or if it is blocking doing another, I might merge it, but should say so first.
There was a problem hiding this comment.
Thank you, that's very helpful. I think this one looks OK and you've approved it, so I'll merge it soon.
|
Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2019
(cherry picked from commit ed1deb0) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-12069 is a backport of this pull request to the 3.7 branch. |
|
|
|
Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2019
(cherry picked from commit ed1deb0) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-12075 is a backport of this pull request to the 3.7 branch. |
|
As will nearly always be the case, these post-merge buildbot failure reports are 'false positives' in relation to the merge. Both are failures in test_urllib2net. Looking at https://buildbot.python.org/all/#/console, it appears that the two merges before this broke almost everything. |
terryjreedy
pushed a commit
that referenced
this pull request
Feb 27, 2019
…-12075) (cherry picked from commit ed1deb0) Co-authored-by: Cheryl Sabella <[email protected]>
|
You added the 'need backport to 3.7' label to the closed PR and it started the backporting process all over again? That's a good trick to know about! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor class variables to instance variables in
colorizer.py.https://bugs.python.org/issue36096