Skip to content

Paragraphs with leading similar #121135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Jun 28, 2024

When translating Doc/c-api/dict, I noticed that there was a paragraph starting with "Similar " and other "This is similar", so this is to propose a uniformization. Also, there is a "Similar than", which AFAIK is not correct.


📚 Documentation preview 📚: https://cpython-previews--121135.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Jun 28, 2024
@hauntsaninja hauntsaninja added needs backport to 3.13 bugs and security fixes skip issue and removed skip issue labels Jul 2, 2024
@hauntsaninja hauntsaninja merged commit 4f1e1df into python:main Jul 2, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@rffontenelle rffontenelle deleted the patch-4 branch July 2, 2024 01:10
Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Feb 20, 2025
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @rffontenelle and @hauntsaninja, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4f1e1dff8928e626924ee1ff70a77af1a14f0f2a 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
(cherry picked from commit 4f1e1df)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130364 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 20, 2025
@hugovk
Copy link
Member

hugovk commented Feb 20, 2025

3.12 backport not needed, this text was added in 3.13.

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Feb 20, 2025
hugovk pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants