gh-121711: Set -m asyncio return_code to 1 for ENOTTY
#121714
Conversation
zvyn
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
| def test_asyncio_repl_is_ok(self): | ||
| assert_python_ok("-m", "asyncio") | ||
| def test_asyncio_repl_no_tty_fails(self): | ||
| assert assert_python_failure("-m", "asyncio") |
There was a problem hiding this comment.
How do we now know that the asyncio REPL is not working? Initially, test_asyncio_repl_is_ok was added because the asyncio repl is not working on Windows due to a bug.
Additionally: We don't use assert statement in our test suite.
There was a problem hiding this comment.
The fact that the new test passes means that assert_python_ok never tested weather the repl works.
I think t should be testet without setting stdin on Popen (inside assert_python_ok).
I can add that test, but it will fail because of another bug I found and am intending to fix soonish (report pending, easy to reproduce by running python -m asyncio from the main branch).
There was a problem hiding this comment.
@Eclips4 asyncio REPL is currently broken and this wasn't caught.
There was a problem hiding this comment.
The fact that the new test passes means that
assert_python_oknever tested weather the repl works.I think t should be testet without setting
stdinonPopen(insideassert_python_ok).I can add that test, but it will fail because of another bug I found and am intending to fix soonish (report pending, easy to reproduce by running
python -m asynciofrom the main branch).
Yes, you're right, I'm also experiencing the problem with python -m asyncio:
./python -m asyncio
asyncio REPL 3.14.0a0 (heads/main:dc03ce797a, Jul 13 2024, 15:05:30) [GCC 13.2.0] on linux
Use "await" directly instead of "asyncio.run()".
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
TypeError: run_multiline_interactive_console() missing 1 required positional argument: 'namespace'
Internal error, exiting asyncio REPL...
…GH-121714) Set return_code to 1 for ENOTTY (cherry picked from commit a183474) Co-authored-by: Milan Oberkirch <[email protected]>
|
GH-121718 is a backport of this pull request to the 3.13 branch. |
…1714) (GH-121718) Set return_code to 1 for ENOTTY (cherry picked from commit a183474) Co-authored-by: Milan Oberkirch <[email protected]>
…#121714) Set return_code to 1 for ENOTTY
See #121711 for details
python -m asyncioreturns 0 when failing with ENOTTY in the runner thread #121711