Skip to content

[3.7] bpo-29571: Fix test_re.test_locale_flag() #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2019
Merged

[3.7] bpo-29571: Fix test_re.test_locale_flag() #12178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59aad8d
bpo-29571: Fix test_re.test_locale_flag()
vstinner Mar 5, 2019
6368e30
Add NEWS entry
vstinner Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Lib/test/test_re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,8 +1516,18 @@ def test_ascii_and_unicode_flag(self):
self.assertRaises(re.error, re.compile, r'(?au)\w')

def test_locale_flag(self):
import locale
_, enc = locale.getlocale(locale.LC_CTYPE)
# On Windows, Python 3.7 doesn't call setlocale(LC_CTYPE, "") at
# startup and so the LC_CTYPE locale uses Latin1 encoding by default,
# whereas getpreferredencoding() returns the ANSI code page. Set
# temporarily the LC_CTYPE locale to the user preferred encoding to
# ensure that it uses the ANSI code page.
oldloc = locale.setlocale(locale.LC_CTYPE, None)
locale.setlocale(locale.LC_CTYPE, "")
self.addCleanup(locale.setlocale, locale.LC_CTYPE, oldloc)

# Get the current locale encoding
enc = locale.getpreferredencoding(False)

# Search non-ASCII letter
for i in range(128, 256):
try:
Expand Down
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/Tests/2019-03-05-13-48-39.bpo-29571.ecGuKR.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fix ``test_re.test_locale_flag()``: use ``locale.getpreferredencoding()``
rather than ``locale.getlocale()`` to get the locale encoding. With some
locales, ``locale.getlocale()`` returns the wrong encoding. On Windows, set
temporarily the ``LC_CTYPE`` locale to the user preferred encoding to ensure
that it uses the ANSI code page, to be consistent with
``locale.getpreferredencoding()``.