Skip to content

bpo-36210: correct logic in setup.py for optional extensions with regard to AIX #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 21, 2019
Merged

bpo-36210: correct logic in setup.py for optional extensions with regard to AIX #12202

merged 12 commits into from
Jun 21, 2019

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Mar 6, 2019 •
edited
Loading

There are three optional modules that either will never exist (spwd and osaudiodev) or would build correctly if the OS provided library was preferred rather than an optionally installed, non-supported 3rd-party library (ncurses).

  • This PR sets AIX to build _curses against the IBM supported /usr/lib/libcurses.a and skip the optional _cursus_panel.

    • Python _curses module builds with no issues from AIX 5.3 through AIX 7.2 when using the officially supported libcurses.a
    • When a third-party packaging of ncurses is installed neither _curses nor _cursus_panel build successfully.

  • setup.py no longer says _spwd and _osaudiodev are missing (something) when building for AIX

https://bugs.python.org/issue36210

ZackerySpytz
ZackerySpytz reviewed Mar 31, 2019
View reviewed changes
@aixtools aixtools changed the title bpo-36210: Switch to officially support curses from ASIS supported ncurses bpo-36210: correct AIX logic in setup.py for optional extensions Apr 2, 2019
@aixtools aixtools changed the title bpo-36210: correct AIX logic in setup.py for optional extensions bpo-36210: correct logic in setup.py for optional extensions with regard to AIX Apr 2, 2019
@aixtools
Copy link
Contributor Author

Question: what is the current status of spwd module in Python? Is this something I should look at seeing if I can emulate in AIX (i.e., not using getspent() etc, functions, but the AIX ones for accessing shadow information).

I thought I heard that spwd will be removed - sometime.

If spwd is going to stay forever, then the missing announcement may be useful, but asis, it is just some noise.

@aixtools aixtools closed this Jun 20, 2019
@aixtools aixtools reopened this Jun 20, 2019
@ncoghlan
Copy link
Contributor

spwd is one of the libraries on the removal list in PEP 594: https://www.python.org/dev/peps/pep-0594/#spwd

ncoghlan
ncoghlan requested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly seems fine to me, but I'd prefer to update the curses_panel logic to make it more obviously free of potential side effects on other platforms.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aixtools
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ncoghlan: please review the changes made to this pull request.

@ncoghlan ncoghlan merged commit 08970cb into python:master Jun 21, 2019
@miss-islington
Copy link
Contributor

Thanks @aixtools for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@aixtools @lisroach
bpo-36210: update optional extension handling for AIX (pythonGH-12202)
24a479b 
* Switch to officially supported curses from 3rd-party ASIS supported ncurses
* stop saying optional modules osaudiodev and spwd are missing on AIX

Patch by M.Felt
aixtools added a commit to aixtools/cpython that referenced this pull request Sep 25, 2019
@aixtools
bpo-36210: correct logic in setup.py for optional extensions for AIX (p…
c53cfaf 
…ythonGH-12202)

patch by M Felt
@aixtools
Copy link
Contributor Author

Added #16376 as backport.

@bedevere-bot
Copy link

GH-16376 is a backport of this pull request to the 3.8 branch.

ned-deily pushed a commit that referenced this pull request Sep 25, 2019
@aixtools @ned-deily
bpo-36210: correct logic in setup.py for optional extensions for AIX (G…
e4be8c9 
…H-12202) (GH-16376)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@aixtools @DinoV
bpo-36210: update optional extension handling for AIX (pythonGH-12202)
300e76a 
* Switch to officially supported curses from 3rd-party ASIS supported ncurses
* stop saying optional modules osaudiodev and spwd are missing on AIX

Patch by M.Felt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aixtools @ncoghlan @bedevere-bot @miss-islington @ZackerySpytz @the-knights-who-say-ni