Skip to content

gh-122188: Remove _imp.pyc_magic_number #122503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

gh-122188: Remove _imp.pyc_magic_number #122503

merged 1 commit into from
Aug 2, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 31, 2024 •
edited by bedevere-app bot
Loading

_imp.pyc_magic_number_token should be enough.

@serhiy-storchaka
pythongh-122188: Remove _imp.pyc_magic_number
0e1d8e4 
_imp.pyc_magic_number_token should be enough.
@bedevere-app bedevere-app bot mentioned this pull request Jul 31, 2024
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 31, 2024
Merged
mdboom
mdboom approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mdboom mdboom added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdboom for commit 0e1d8e4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2024
@mdboom
Copy link
Contributor

mdboom commented Jul 31, 2024

I scheduled a buildbot test just to make sure this gets testing on a big-endian platform.

@serhiy-storchaka serhiy-storchaka merged commit 03b8852 into python:main Aug 2, 2024
110 of 112 checks passed
@serhiy-storchaka serhiy-storchaka deleted the remove-pyc_magic_number branch August 2, 2024 10:12
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@serhiy-storchaka @brandtbucher
pythongh-122188: Remove _imp.pyc_magic_number (pythonGH-122503)
2c07d58 
_imp.pyc_magic_number_token should be enough.
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@serhiy-storchaka @blhsing
pythongh-122188: Remove _imp.pyc_magic_number (pythonGH-122503)
40a734b 
_imp.pyc_magic_number_token should be enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom approved these changes

@brettcannon brettcannon brettcannon approved these changes

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @bedevere-bot @mdboom @brettcannon