Skip to content

gh-89683: add tests for deepcopy on frozen dataclasses #123098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2024
Merged

gh-89683: add tests for deepcopy on frozen dataclasses #123098

merged 3 commits into from
Sep 26, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 17, 2024 •
edited
Loading

Note that I did not change the existing behaviour. Should we, in the case the user defines their own slot, automatically add __{get,set}state__ methods if they are not provided?

@picnixz picnixz requested a review from ericvsmith as a code owner August 17, 2024 11:12
@bedevere-app bedevere-app bot mentioned this pull request Aug 17, 2024
Closed
@picnixz picnixz changed the title gh-89783: add tests for deepcopy on frozen dataclasses gh-89683: add tests for deepcopy on frozen dataclasses Aug 17, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 17, 2024
Closed
@ericvsmith ericvsmith added 3.12 only security fixes 3.13 bugs and security fixes labels Sep 26, 2024
@ericvsmith ericvsmith self-assigned this Sep 26, 2024
@ericvsmith ericvsmith enabled auto-merge (squash) September 26, 2024 20:44
@ericvsmith ericvsmith merged commit 5e7eba0 into python:main Sep 26, 2024
32 checks passed
@ericvsmith ericvsmith added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 only security fixes 3.13 bugs and security fixes labels Sep 26, 2024
@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @picnixz and @ericvsmith, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5e7eba09bcdafe361b491b3f8cf30d7dd2df0a78 3.13

@miss-islington-app
Copy link

Sorry, @picnixz and @ericvsmith, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5e7eba09bcdafe361b491b3f8cf30d7dd2df0a78 3.12

ericvsmith added a commit to ericvsmith/cpython that referenced this pull request Sep 26, 2024
@picnixz @ericvsmith
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho…
8286e67 
…ngh-123098)

Co-authored-by: Eric V. Smith <[email protected]>
(cherry picked from commit 5e7eba0)
@picnixz picnixz deleted the 89683-frozen-dataclass-deep-copy-with-slots branch September 26, 2024 21:27
@picnixz
Copy link
Member Author

picnixz commented Sep 27, 2024

Erf, backports failed. I'll take care of them now.

@ericvsmith
Copy link
Member

@picnixz : Thanks!

picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho…
7f4762a 
…ngh-123098)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Eric V. Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124678 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 27, 2024
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho…
02ce930 
…ngh-123098)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Eric V. Smith <[email protected]>

# Conflicts:
#	Lib/test/test_dataclasses/__init__.py
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
pythongh-89683: add tests for deepcopy on frozen dataclasses (pytho…
f4b65bf 
…ngh-123098)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Eric V. Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2024

GH-124679 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 27, 2024
@picnixz
Copy link
Member Author

picnixz commented Sep 27, 2024

Backports are ready (I really hate making backports manually because cherry_picker tells me I'm outside a CPython repository).

@ericvsmith
Copy link
Member

You're better than me: I tried using cherry_picker and failed. Thanks for the backports.

ericvsmith added a commit that referenced this pull request Sep 27, 2024
@picnixz @ericvsmith
[3.12] gh-89683: add tests for deepcopy on frozen dataclasses (GH-1…
373036a 
…23098) (gh-124679)

gh-89683: add tests for `deepcopy` on frozen dataclasses (gh-123098)

Co-authored-by: Eric V. Smith <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@picnixz @ericvsmith
[3.13] gh-89683: add tests for deepcopy on frozen dataclasses (GH-1…
6b847be 
…23098) (#124678)

* gh-89683: add tests for `deepcopy` on frozen dataclasses (gh-123098)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Eric V. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@ericvsmith ericvsmith

Labels
skip news topic-dataclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @ericvsmith