Change WriterObj.writeline to WriterObj.write #12344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remilapeyre, this isn't a trivial issue, so it would require a bpo issue. Thanks! |
|
Usually, we discourage PRs like this: it just renames the internal name without providing any extra functionality or bug fixing. |
|
@remilapeyre, thank you for the suggestion, but I'l close this based on @asvetlov's comment. |
|
Hi @asvetlov, @csabella ! It was asked by @vstinner in #12306 (comment) as the previous naming was misleading. |
|
Ok, I'm fine then. |
asvetlov
approved these changes
May 14, 2019
|
@remilapeyre: Status check is done, and it's a success ✅ . |
|
Thanks, @remilapeyre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans the csv module a bit, I don't think it requires a bpo issue or a news entry.