Skip to content

gh-123716: Fix 'Bad substitution' syntax error in configure script for NetBSD compatibility #123717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2024
Merged

gh-123716: Fix 'Bad substitution' syntax error in configure script for NetBSD compatibility #123717

merged 2 commits into from
Sep 5, 2024

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Sep 4, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 4, 2024
Closed
vstinner
vstinner approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @erlend-aasland @freakboy3742

@vstinner
Copy link
Member

vstinner commented Sep 5, 2024

You should run regen-configure: see https://docs.python.org/dev/using/configure.html#configure-script

freakboy3742
freakboy3742 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Sep 5, 2024
@vstinner vstinner enabled auto-merge (squash) September 5, 2024 23:41
@vstinner vstinner merged commit 42f5243 into python:main Sep 5, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2024
@furkanonder @miss-islington
pythongh-123716: Fix 'Bad substitution' syntax error in configure scr…
4aafea7 
…ipt for NetBSD compatibility (pythonGH-123717)

(cherry picked from commit 42f5243)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2024

GH-123752 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 5, 2024
Yhg1s pushed a commit that referenced this pull request Sep 6, 2024
@miss-islington @furkanonder
[3.13] gh-123716: Fix 'Bad substitution' syntax error in configure sc…
e68f30e 
…ript for NetBSD compatibility (GH-123717) (#123752)

gh-123716: Fix 'Bad substitution' syntax error in configure script for NetBSD compatibility (GH-123717)
(cherry picked from commit 42f5243)

Co-authored-by: Furkan Onder <[email protected]>
@furkanonder furkanonder added the build The build process and cross-build label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
build The build process and cross-build skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkanonder @vstinner @freakboy3742