Skip to content

GH-79714: Add mention of stderr for clarity to ArgumentParser.exit() #123932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2024
Merged

GH-79714: Add mention of stderr for clarity to ArgumentParser.exit() #123932

merged 7 commits into from
Sep 23, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Sep 11, 2024 •
edited by github-actions bot
Loading

This PR adds a tiny clarification about how ArgumentParser.exit() prints to stderr.

📚 Documentation preview 📚: https://cpython-previews--123932.org.readthedocs.build/

@savannahostrowski savannahostrowski added skip news 3.14 bugs and security fixes labels Sep 11, 2024
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir labels Sep 11, 2024
savannahostrowski
savannahostrowski commented Sep 11, 2024
View reviewed changes
@savannahostrowski savannahostrowski changed the title GH-79714: add mention of stderr for clarity to exit() GH-79714: add mention of stderr for clarity to ArgumentParser.exit() Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Closed
serhiy-storchaka
serhiy-storchaka reviewed Sep 22, 2024
View reviewed changes
@serhiy-storchaka serhiy-storchaka changed the title GH-79714: add mention of stderr for clarity to ArgumentParser.exit() GH-79714: Add mention of stderr for clarity to ArgumentParser.exit() Sep 22, 2024
serhiy-storchaka
serhiy-storchaka reviewed Sep 22, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka added 3.12 only security fixes 3.13 bugs and security fixes labels Sep 23, 2024
@serhiy-storchaka serhiy-storchaka merged commit 5f5c0b9 into python:main Sep 23, 2024
27 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes labels Sep 23, 2024
@miss-islington-app
Copy link

Thanks @savannahostrowski for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @savannahostrowski for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
@savannahostrowski @miss-islington
pythonGH-79714: Add mention of stderr for clarity to ArgumentParser.e…
7613908 
…xit() (pythonGH-123932)

(cherry picked from commit 5f5c0b9)

Co-authored-by: Savannah Ostrowski <[email protected]>
@miss-islington-app
Copy link

Sorry, @savannahostrowski and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5f5c0b9c23238dc0a1fdb764f625ae0cc5604519 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124331 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024
@serhiy-storchaka
Copy link
Member

The conflict is because deprecated did not exist in 3.12. It should not be hard to resolve it. @savannahostrowski, do you mind to create a backport?

savannahostrowski added a commit to savannahostrowski/cpython that referenced this pull request Sep 23, 2024
@savannahostrowski
[3.12] pythonGH-79714: Add mention of stderr for clarity to ArgumentP…
ba0965b 
…arser.exit() (pythonGH-123932)

(cherry picked from commit 5f5c0b9)

Co-authored-by: Savannah Ostrowski <[email protected]>
@savannahostrowski savannahostrowski mentioned this pull request Sep 23, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124356 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 23, 2024
serhiy-storchaka pushed a commit that referenced this pull request Sep 23, 2024
@savannahostrowski
[3.12] GH-79714: Add mention of stderr for clarity to ArgumentParser.…
b370956 
…exit() (GH-123932) (GH-124356)

(cherry picked from commit 5f5c0b9)
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @savannahostrowski
[3.13] GH-79714: Add mention of stderr for clarity to ArgumentParser.…
a052faf 
…exit() (GH-123932) (#124331)

GH-79714: Add mention of stderr for clarity to ArgumentParser.exit() (GH-123932)
(cherry picked from commit 5f5c0b9)

Co-authored-by: Savannah Ostrowski <[email protected]>
@savannahostrowski savannahostrowski deleted the gh-79714 branch September 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savannahostrowski @serhiy-storchaka