-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-122957: Fix test flakiness in free-thread build #124039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-122957: Fix test flakiness in free-thread build #124039
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Should we backport this to 3.12 and 3.13? |
I think we've only ever seen the flakiness on the free-threaded build, so a backport to 3.12 is probably not necessary, although I think this is a pretty low risk change. A backport to 3.13 would be good. Otherwise, we'll probably see flaky test failures in the free-threading buildbots. It's not urgent though, and can wait until after the final release if that's more convenient. |
OK, let's merge this and it'll be up to Thomas whether to merge the 3.13 backport, or we can just do it after 3.13.0 goes out. |
Thanks @lesteve for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ild (pythonGH-124039) (cherry picked from commit eadb966) Co-authored-by: Loïc Estève <[email protected]>
GH-124067 is a backport of this pull request to the 3.13 branch. |
Fix #122957.
Locally I tested this by running the test 1000 times with the command and the diff below. It fails around 10-20 times out of 1000 on
main
and does not fail out of 1000 times with the fix on this PR.test_asyncio
test_to_thread_concurrent
flaky #122957