Skip to content

[3.12] Add some doctest cleanups for configparser (GH-125288) #125291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 10, 2024

(cherry picked from commit a726ce7 -- but just the configparser changes)

Co-authored-by: Alex Waygood [email protected]
Co-authored-by: Adam Turner [email protected]


📚 Documentation preview 📚: https://cpython-previews--125291.org.readthedocs.build/

…25288)

(cherry picked from commit a726ce7)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@AA-Turner
Copy link
Member

FileNotFoundError: [Errno 2] No such file or directory: 'my_drawing.ps' - probably because #123617 wasn't backported.

A

Comment on lines 19 to 20
import os
os.remove("my_drawing.ps")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as on the 3.13 PR:

Suggested change
import os
os.remove("my_drawing.ps")
# Destroy the turtle window after tests are complete
# Imported via star import in testsetup
bye()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave this for now, same rationale as #125290 (comment)

@AlexWaygood AlexWaygood changed the title [3.12] Add some doctest cleanups for turtle and configparser (GH-125288) [3.12] Add some doctest cleanups for configparser (GH-125288) Oct 11, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) October 11, 2024 09:47
@AlexWaygood AlexWaygood merged commit 7c48c63 into python:3.12 Oct 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants