Skip to content

gh-125875: Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC #126319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

rimi0108
Copy link
Contributor

@rimi0108 rimi0108 commented Nov 2, 2024

@ghost
Copy link

ghost commented Nov 2, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@rimi0108
Copy link
Contributor Author

rimi0108 commented Nov 2, 2024

@corona10

@corona10 corona10 added the needs backport to 3.13 bugs and security fixes label Nov 2, 2024
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to changelog

[gh-33092](https://github.com/python/cpython/issues/33092): Simplify and speed up interpreter for f-strings. Removes FORMAT_VALUE opcode. Add CONVERT_VALUE, FORMAT_SIMPLE and FORMAT_WITH_SPEC opcode. Compiler emits more efficient sequence for each format expression.

@corona10
Copy link
Member

corona10 commented Nov 2, 2024

But I would like to leave a chance to review from @willingc , @Mariatta or @hugovk

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @rimi0108 and congrats on your contribution. @corona10 feel free to merge and celebrate 🎉

@corona10 corona10 merged commit 914356f into python:main Nov 2, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @rimi0108 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2024
…ngh-126319)

Fix docs typo FORMAT_SPEC to FORMAT_WITH_SPEC
(cherry picked from commit 914356f)

Co-authored-by: rimchoi <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 2, 2024

GH-126320 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 2, 2024
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants