-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Fix example code in curses tutorial #126446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error in the example code illustrating the usage of the `wrapper` method in the curses tutorial which causes it to run through all iterations of the loop and error out before displaying anything on screen or waiting for user input.
ZeroIntensity
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @picnixz
picnixz
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job spotting this!
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 10, 2025
(cherry picked from commit 5fbe23e) Co-authored-by: Jiayu Yi <[email protected]>
GH-132362 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Jiayu Yi <[email protected]>
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error in the example code in the curses tutorial illustrating the usage of the
wrapper
method which causes it to run through all iterations of the loop and error out before displaying anything on screen or waiting for user input.📚 Documentation preview 📚: https://cpython-previews--126446.org.readthedocs.build/