-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-126451: Register contextvars.Context to collections.abc.Mapping #126452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
74b3631
Register contextvars.Context to collections.abc.Mapping
tungol 9c4e3f5
test that all the methods are present
tungol 3a1f8b2
test for callability, sort methods alphabetically in the test
tungol 8c68b5b
minor spacing
tungol aa0da03
Update Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.X…
tungol 72d6726
import _collections_abc instead of collections.abc
tungol b0c38e8
use subtests
tungol 96e2280
add issubclass check
tungol 5cdad6a
Update Lib/test/test_context.py
tungol 0e0a5e6
fix duplicate line
tungol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
import _collections_abc | ||
from _contextvars import Context, ContextVar, Token, copy_context | ||
|
||
|
||
__all__ = ('Context', 'ContextVar', 'Token', 'copy_context') | ||
|
||
|
||
_collections_abc.Mapping.register(Context) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.XJMtqz.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Register the :class:`contextvars.Context` type to | ||
:class:`collections.abc.Mapping`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.