Skip to content

bpo-21879: Improve exception message for str.format #12675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Objects/stringlib/unicode_format.h
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,13 @@ get_field_object(SubString *input, PyObject *args, PyObject *kwargs,

/* look up in args */
obj = PySequence_GetItem(args, index);
if (obj == NULL)
goto error;
if (obj == NULL) {
PyErr_Format(PyExc_IndexError,
"Replacement index %zd out of range for positional "
"args tuple",
index);
goto error;
}
}

/* iterate over the rest of the field_name */
Expand Down