Skip to content

Fix tense build to built #12686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix tense build to built #12686

merged 1 commit into from
Apr 10, 2019

Conversation

calebmarchent
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 4, 2019
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a straightforward fix to the grammar, I'm not sure it needs NEWS (CLA might be legally arguable as well since it may not meet the minimum requirements to be copyrightable, but better safe than sorry on that).

@calebmarchent
Copy link
Contributor Author

I sent the signed CLA through AdobeSign on 4th April; but have not seen a response?

@tirkarthi
Copy link
Member

tirkarthi commented Apr 8, 2019

https://check-python-cla.herokuapp.com/ indicates it's signed.

Edit: The label changed as I posted the comment

@calebmarchent
Copy link
Contributor Author

All we need now is the "skip issue" and "skip news" tags and someone with commit access can merge.

@pganssle
Copy link
Member

CC: @willingc @merwok as the two people on the "experts list" for documentation whose github names I know 😉.

I think we just need the skip news and skip issue labels, then this can be merged. I'd also say a backport to 3.7, since this typo is also present in the 3.7 documentation.

@bedevere-bot
Copy link

@merwok: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @calebmarchent for the PR, and @merwok for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@merwok
Copy link
Member

merwok commented Apr 10, 2019

@python/cpython-bots The #/GH thing is still annoying. Can there be a way to write the desired commit message then use automerge?

@merwok
Copy link
Member

merwok commented Apr 10, 2019

Thanks for the patch!

@calebmarchent
Copy link
Contributor Author

Thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants