-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Fix tense build to built #12686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tense build to built #12686
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a straightforward fix to the grammar, I'm not sure it needs NEWS (CLA might be legally arguable as well since it may not meet the minimum requirements to be copyrightable, but better safe than sorry on that).
I sent the signed CLA through AdobeSign on 4th April; but have not seen a response? |
https://check-python-cla.herokuapp.com/ indicates it's signed. Edit: The label changed as I posted the comment |
All we need now is the "skip issue" and "skip news" tags and someone with commit access can merge. |
CC: @willingc @merwok as the two people on the "experts list" for documentation whose github names I know 😉. I think we just need the skip news and skip issue labels, then this can be merged. I'd also say a backport to 3.7, since this typo is also present in the 3.7 documentation. |
@merwok: Please replace |
Thanks @calebmarchent for the PR, and @merwok for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
@python/cpython-bots The #/GH thing is still annoying. Can there be a way to write the desired commit message then use automerge? |
Thanks for the patch! |
Thanks for the merge :) |
No description provided.