Skip to content

gh-85957: Add missing MIME types for images with RFCs #126966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 18, 2024
Merged

gh-85957: Add missing MIME types for images with RFCs #126966

merged 7 commits into from
Nov 18, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 18, 2024 •
edited by github-actions bot
Loading

Closes #85957.

I checked the list of MIME types with RFCs at https://www.iana.org/assignments/media-types/media-types.xhtml#image

Already present:

Name Template Reference
bmp image/bmp RFC7903
gif image/gif RFC2045 RFC2046
ief image/ief RFC1314
jpeg image/jpeg RFC2045 RFC2046
tiff image/tiff RFC3302
webp image/webp RFC-zern-webp-15

Added in this PR:

Name Template Reference
emf image/emf RFC7903
fits image/fits RFC4047
g3fax image/g3fax RFC1494
jp2 image/jp2 RFC3745
jpm image/jpm RFC3745
jpx image/jpx RFC3745 ISO-IEC_JTC_1_SC_29_WG_1
t38 image/t38 RFC3362
tiff-fx image/tiff-fx RFC3950
wmf image/wmf RFC7903

Omitted:

Name Template Reference
example image/example RFC4735
x-emf - DEPRECATED in favor of image/emf image/x-emf RFC7903
x-wmf - DEPRECATED in favor of image/wmf image/x-wmf RFC7903

📚 Documentation preview 📚: https://cpython-previews--126966.org.readthedocs.build/

@hugovk hugovk added the type-feature A feature request or enhancement label Nov 18, 2024
@hugovk hugovk requested a review from a team as a code owner November 18, 2024 13:29
@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2024
Closed
asvetlov
asvetlov approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugovk hugovk merged commit 933f21c into python:main Nov 18, 2024
39 of 40 checks passed
@hugovk hugovk deleted the 85957-add-jp2-mimetype branch November 18, 2024 18:13
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
pythongh-85957: Add missing MIME types for images with RFCs (python#1…
2d53a34 
…26966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mimetypes module does not recognize jp2 type
2 participants
@hugovk @asvetlov