Skip to content

gh-127629: Add ctypes to the Emscripten build #127683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2024
Merged

gh-127629: Add ctypes to the Emscripten build #127683

merged 6 commits into from
Dec 10, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 6, 2024
Closed
@hoodmane hoodmane removed the request for review from brettcannon December 6, 2024 11:47
freakboy3742
freakboy3742 requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this works fine; a couple of questions inline about documentation and gross structure.

@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hoodmane
Copy link
Contributor Author

hoodmane commented Dec 9, 2024

I have made the requested changes; please review again. Thanks @freakboy3742!

@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2024

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from freakboy3742 December 9, 2024 19:06
freakboy3742
freakboy3742 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those fixes - this looks great!

@freakboy3742 freakboy3742 merged commit 3b18af9 into python:main Dec 10, 2024
51 of 54 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127629: Add ctypes to the Emscripten build (python#127683)
655b380 
Adds tooling to build libffi and add ctypes to the stdlib for Emscripten.
MichaelBuhler
MichaelBuhler reviewed Apr 8, 2025
View reviewed changes
Tools/wasm/emscripten/make_libffi.sh
export EM_PKG_CONFIG_PATH="$PKG_CONFIG_PATH"

# Specific variables for cross-compilation
export CHOST="wasm32-unknown-linux" # wasm32-unknown-emscripten
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this end up being wasm32-unknown-linux instead of wasm32-unknown-emscripten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Maybe I put it that way while debugging and didn't notice before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBuhler MichaelBuhler MichaelBuhler left review comments

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
OS-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoodmane @freakboy3742 @MichaelBuhler