Skip to content

bpo-36601: clarify signal handler comment and remove unnecessary pid check. #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2019
Merged

bpo-36601: clarify signal handler comment and remove unnecessary pid check. #12784

merged 2 commits into from
May 10, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Apr 11, 2019 •
edited by bedevere-bot
Loading

@gpshead
Copy link
Member

gpshead commented Apr 12, 2019

I suggest adding a NEWS entry that says something along the lines of "A believed now-meaningless internal check for getpid() == main_pid was removed from Python's signal handler."

@gpshead gpshead self-assigned this Apr 12, 2019
gpshead
gpshead approved these changes Apr 12, 2019
View reviewed changes
@jdemeyer
Copy link
Contributor Author

I suggest adding a NEWS entry that says something along the lines of "A believed now-meaningless internal check for getpid() == main_pid was removed from Python's signal handler."

Done.

@jdemeyer
Copy link
Contributor Author

This was set to "awaiting merge" almost 2 weeks ago. Can this actually be merged please?

@merwok
Copy link
Member

merwok commented May 3, 2019

I find believed now-meaningless internal a little hard to parse

@gpshead
Copy link
Member

gpshead commented May 10, 2019

heh thanks, i cleaned up the news entry wording.

@gpshead gpshead changed the title bpo-36601: comment that signals can be caught by any thread bpo-36601: clarify signal handler comment and remove unnecessary pid check. May 10, 2019
@miss-islington
Copy link
Contributor

@jdemeyer: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d237b3f into python:master May 10, 2019
@jdemeyer jdemeyer deleted the bpo36601 branch June 26, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jdemeyer @gpshead @merwok @miss-islington @the-knights-who-say-ni @bedevere-bot