bpo-36651: Fixed Asyncio Event Loop documentation inconsistency #12866
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
| @@ -0,0 +1 @@ | |||
| bpo-36651: Fixed Asyncio Event Loop documentation inconsistency | |||
There was a problem hiding this comment.
There is an error in Travis due to this blurb entry at https://travis-ci.org/python/cpython/jobs/521431229#L309 . I am not sure this doc change needs a news entry.
blurb.BlurbError: Error in Misc/NEWS.d/next/Documentation/2019-04-17-20-21-32.bpo-36651.3iUjvY.rst:0:
Blurb 'body' can't start with 'bpo-'!
Removing file not passing bot checking
The change is small and self-descriptive. There is no need for changelog record in this case
|
Sorry, I can't merge this PR. Reason: |
|
Thanks @naccht for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…onGH-12866) GH- [bpo-36651](https://bugs.python.org/issue36651): Fixed Asyncio Event Loop documentation inconsistency In the documentation for the call_later and the call_at methods there is a note which says that the delay cannot be longer than a day, but both methods have a note saying that this limitation was removed in Python 3.8 Here I fixed this issue by removing the pre-exising note and added a versionchanged. To test my changes I have rebuilt the documentation with ```make html```. I did not have any errors and the effected page displayed correctly on a browser. https://bugs.python.org/issue36651 (cherry picked from commit 7e954e7) Co-authored-by: Enrico Alarico Carbognani <[email protected]>
|
GH-12874 is a backport of this pull request to the 3.7 branch. |
…2866) GH- [bpo-36651](https://bugs.python.org/issue36651): Fixed Asyncio Event Loop documentation inconsistency In the documentation for the call_later and the call_at methods there is a note which says that the delay cannot be longer than a day, but both methods have a note saying that this limitation was removed in Python 3.8 Here I fixed this issue by removing the pre-exising note and added a versionchanged. To test my changes I have rebuilt the documentation with ```make html```. I did not have any errors and the effected page displayed correctly on a browser. https://bugs.python.org/issue36651 (cherry picked from commit 7e954e7) Co-authored-by: Enrico Alarico Carbognani <[email protected]>
bpo-36651: Fixed Asyncio Event Loop documentation inconsistency
In the documentation for the call_later and the call_at methods there is a note which says that the delay cannot be longer than a day, but both methods have a note saying that this limitation was removed in Python 3.8
Here I fixed this issue by removing the pre-exising note and added a versionchanged.
To test my changes I have rebuilt the documentation with
make html. I did not have any errors and the effected page displayed correctly on a browser.https://bugs.python.org/issue36651