gh-128916: Do not set SO_REUSEPORT on non-AF_INET* sockets
#128933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer.
mgorny
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
vsajip
reviewed
Jan 17, 2025
Misc/NEWS.d/next/Library/2025-01-17-11-46-16.gh-issue-128916.GEePbO.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Vinay Sajip <[email protected]>
gpshead
approved these changes
Jan 18, 2025
gpshead
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2025
…ythonGH-128933) * pythongh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review Co-authored-by: Vinay Sajip <[email protected]> --------- (cherry picked from commit 3829104) Co-authored-by: Michał Górny <[email protected]> Co-authored-by: Vinay Sajip <[email protected]>
|
GH-128969 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2025
…ythonGH-128933) * pythongh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review Co-authored-by: Vinay Sajip <[email protected]> --------- (cherry picked from commit 3829104) Co-authored-by: Michał Górny <[email protected]> Co-authored-by: Vinay Sajip <[email protected]>
|
GH-128970 is a backport of this pull request to the 3.12 branch. |
gpshead
pushed a commit
that referenced
this pull request
Jan 18, 2025
…GH-128933) (#128970) gh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets (GH-128933) * gh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review --------- (cherry picked from commit 3829104) Co-authored-by: Michał Górny <[email protected]> Co-authored-by: Vinay Sajip <[email protected]>
gpshead
pushed a commit
that referenced
this pull request
Jan 18, 2025
…GH-128933) (#128969) gh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets (GH-128933) * gh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review --------- (cherry picked from commit 3829104) Co-authored-by: Michał Górny <[email protected]> Co-authored-by: Vinay Sajip <[email protected]>
|
Thanks! The test failure only affected 3.14, but I guess the change per se makes sense for older branches as well (for user code). |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
…ythonGH-128933) * pythongh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review Co-authored-by: Vinay Sajip <[email protected]> --------- Co-authored-by: Vinay Sajip <[email protected]>
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 21, 2025
…ockets (pythonGH-128933) * pythongh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review Co-authored-by: Vinay Sajip <[email protected]> --------- Co-authored-by: Vinay Sajip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to set
SO_REUSEPORTon sockets of address familifies other thanAF_INETandAF_INET6, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer.socketserver.Unix*Servermay attempt to setSO_REUSEPORTon Unix sockets, causingEOPNOTSUPP, e.g. intest_asyncio#128916