Skip to content

bpo-36748: optimize TextIOWrapper.write() for ASCII string #13002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2019
Merged

bpo-36748: optimize TextIOWrapper.write() for ASCII string #13002

merged 4 commits into from
May 16, 2019

Conversation

methane
Copy link
Member

@methane methane commented Apr 29, 2019 •
edited by bedevere-bot
Loading

@methane methane added the performance Performance or resource usage label Apr 29, 2019
@ZackerySpytz
Copy link
Contributor

I tested this PR locally, and it seems that there are reference leaks (according to ./python -m test -R 3:3 test_io).

test_io leaked [4, 4, 4] references, sum=12
test_io failed in 4 min 12 sec

== Tests result: FAILURE ==

1 test failed:
    test_io

Total duration: 4 min 12 sec
Tests result: FAILURE

@methane methane changed the title bpo-36748: optimize textio write buffering bpo-36748: optimize TextIOWrapper.write() for ASCII string May 16, 2019
@methane methane merged commit bfba8c3 into python:master May 16, 2019
@methane methane deleted the opt-textio-2 branch May 16, 2019 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @ZackerySpytz @the-knights-who-say-ni @bedevere-bot