Skip to content

bpo-36822: Fix minor grammatical error in glossary.rst #13145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2019

Conversation

CuriousLearner
Copy link
Member

@CuriousLearner CuriousLearner commented May 6, 2019

@CuriousLearner
Copy link
Member Author

Hey @pablogsal

Can you please take a look at this?

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks @CuriousLearner for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

Thanks for the fix @CuriousLearner 🎉

@miss-islington
Copy link
Contributor

Sorry, @CuriousLearner and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 90fb04c1e23c0fddd438bd0f73e7c018cacef4bc 3.7

@pablogsal
Copy link
Member

@CuriousLearner Could yo do the backport manually (if is needed)?

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 12, 2019
@bedevere-bot
Copy link

GH-13260 is a backport of this pull request to the 3.7 branch.

@CuriousLearner
Copy link
Member Author

Hey @pablogsal

Here it is: #13260

pablogsal pushed a commit that referenced this pull request May 12, 2019
…. (GH-13260)

(cherry picked from commit 90fb04c)

Co-authored-by: Sanyam Khurana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants