Skip to content

Fix missing bracket #13163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019
Merged

Fix missing bracket #13163

merged 1 commit into from
May 8, 2019

Conversation

azalea
Copy link
Contributor

@azalea azalea commented May 7, 2019

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@matrixise
Copy link
Member

Hi @azalea , please could you create a BPO account and associated your github account to the bpo account. Thank you.

@azalea
Copy link
Contributor Author

azalea commented May 7, 2019

-Hi @matrixise, I just registered a BPO account and signed the CLA. but when I checked it says otherwise. Sorry I am new here. What am I missing?-
An hour after signing, CLA check now works. Thanks.

@miss-islington
Copy link
Contributor

Thanks @azalea for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@matrixise
Copy link
Member

Thank you for your contribution.

@bedevere-bot
Copy link

GH-13189 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2019
(cherry picked from commit 70b8054)

Co-authored-by: Zhaorong Ma <[email protected]>
@matrixise
Copy link
Member

Hi @azalea

For the next time, I suggest to you the reading of the devguide https://devguide.python.org this document explains how to contribute to Python.

Thank you so much for your contrib.

miss-islington added a commit that referenced this pull request May 8, 2019
(cherry picked from commit 70b8054)


Co-authored-by: Zhaorong Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants