Skip to content

gh-131803: Clarify that you must register signal handlers for set_wakeup_fd #131859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

gh-131803: Clarify that you must register signal handlers for set_wakeup_fd #131859

merged 1 commit into from
Apr 14, 2025

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Mar 29, 2025 •
edited by github-actions bot
Loading

@ghost
Copy link

ghost commented Mar 29, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 29, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Mar 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 29, 2025
Closed
vstinner
vstinner approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @picnixz

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
@vstinner vstinner merged commit 939476b into python:main Apr 14, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 14, 2025
@miss-islington-app
Copy link

Thanks @jfly for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2025
@jfly @miss-islington
pythongh-131803: Clarify that you must register signal handlers for s…
a695466 
…et_wakeup_fd (pythonGH-131859)

(cherry picked from commit 939476b)

Co-authored-by: Jeremy Fleischman <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 14, 2025

GH-132522 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 14, 2025
@vstinner
Copy link
Member

Merged, thanks.

@jfly jfly deleted the issue-131803 branch April 14, 2025 16:48
vstinner pushed a commit that referenced this pull request Apr 14, 2025
@miss-islington @jfly
[3.13] gh-131803: Clarify that you must register signal handlers for …
bdff88b 
…set_wakeup_fd (GH-131859) (#132522)

gh-131803: Clarify that you must register signal handlers for set_wakeup_fd (GH-131859)
(cherry picked from commit 939476b)

Co-authored-by: Jeremy Fleischman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signal.set_wakeup_fd does not work unless you register a no-op signal handler for the relevant signal
2 participants
@jfly @vstinner