[3.7] bpo-36807: When saving a file in IDLE, call flush and fsync (GH-13102) #13280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-13102) (cherry picked from commit 4f098b3) Co-authored-by: Guido van Rossum <[email protected]>
terryjreedy
approved these changes
May 13, 2019
|
@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ . |
gvanrossum
approved these changes
May 13, 2019
|
I suppose this needs to be merged manually? IIRC the Azure Pipelines test build is still flaky. |
dhalbert
suggested changes
May 13, 2019
| @@ -0,0 +1 @@ | |||
| When saving a file, call os.flush() so bits are flushed to e.g. USB drive. | |||
There was a problem hiding this comment.
This is a typo, I think, should say call os.fsync().
|
Cannot merge when required test fails, even if irrelevant to patch. I forgot that that cannot close and reopen backport to rerun tests for backport. Will redo backport and correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 4f098b3)
Co-authored-by: Guido van Rossum [email protected]
https://bugs.python.org/issue36807