Skip to content

bpo-36909 Simplify the LastUpdatedOrderedDict example recipe #13296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019
Merged

bpo-36909 Simplify the LastUpdatedOrderedDict example recipe #13296

merged 1 commit into from
May 14, 2019

Conversation

wimglenn
Copy link
Contributor

@wimglenn wimglenn commented May 13, 2019

Recipe in https://docs.python.org/3/library/collections.html#ordereddict-examples-and-recipes

This example seems to use super() unnecessarily. I didn't bother to create a bpo issue number because it seems a trivial docs change to me, but let me know if it's required.

Please add skip news label.

Cheers!

https://bugs.python.org/issue36909

@wimglenn wimglenn requested a review from rhettinger as a code owner May 13, 2019 21:16
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2019
@tonybaloney
Copy link
Contributor

Thanks for your contribution

Yes, it is required. Please add a bpo reference, https://devguide.python.org/pullrequest/

@wimglenn wimglenn changed the title Simplify the LastUpdatedOrderedDict example recipe bpo-36909 Simplify the LastUpdatedOrderedDict example recipe May 13, 2019
@wimglenn
Copy link
Contributor Author

@tonybaloney Added a bpo. What about news entry? Too trivial, no?

@tonybaloney
Copy link
Contributor

Yes, too trivial. there's a special tag that the merger can add

@rhettinger rhettinger merged commit 1a10a6b into python:master May 14, 2019
@miss-islington
Copy link
Contributor

Thanks @wimglenn for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@wimglenn wimglenn deleted the wimglenn-patch-1 branch May 14, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants