bpo-37151: simplify classmethoddescr_call #13340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see a problem merging this with PEP 590. By itself, de-optimizing doesn't make sense to me. |
jdemeyer
force-pushed
the
classmethoddescr_call
branch
from
5075bd2 to
b1064f0
Compare
auvipy
approved these changes
May 31, 2019
jdemeyer
force-pushed
the
classmethoddescr_call
branch
from
b1064f0 to
2b32747
Compare
jdemeyer
changed the title
|
Can this be merged now? |
|
Yes. FWIW, I'm sorry for my current unavailability. I'm busy with the update to 3.8beta1 in Fedora (re-building and re-testing 2000+ Pytohn packages, we do find failures caused – some caused by removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip newssince this is an implementation detail.CC @encukou @markshannon
https://bugs.python.org/issue37151