Skip to content

bpo-36935: Remove usage of the deprecated PyErr_SetFromWindowsErrWithUnicodeFilename() #13355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2019
Merged

bpo-36935: Remove usage of the deprecated PyErr_SetFromWindowsErrWithUnicodeFilename() #13355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
264ed9d
bpo-36935: Remove usage of the deprecated PyErr_SetFromWindowsErrWith…
ZackerySpytz May 16, 2019
04e1e23
Use PyErr_SetExcFromWindowsErrWithFilenameObject().
ZackerySpytz May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Modules/_winapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,9 @@ _winapi_CreateFileMapping_impl(PyObject *module, HANDLE file_handle,
Py_END_ALLOW_THREADS

if (handle == NULL) {
PyErr_SetFromWindowsErrWithUnicodeFilename(0, name);
PyObject *temp = PyUnicode_FromWideChar(name, -1);
PyErr_SetExcFromWindowsErrWithFilenameObject(PyExc_OSError, 0, temp);
Py_XDECREF(temp);
handle = INVALID_HANDLE_VALUE;
}

Expand Down Expand Up @@ -1379,7 +1381,9 @@ _winapi_OpenFileMapping_impl(PyObject *module, DWORD desired_access,
Py_END_ALLOW_THREADS

if (handle == NULL) {
PyErr_SetFromWindowsErrWithUnicodeFilename(0, name);
PyObject *temp = PyUnicode_FromWideChar(name, -1);
PyErr_SetExcFromWindowsErrWithFilenameObject(PyExc_OSError, 0, temp);
Py_XDECREF(temp);
handle = INVALID_HANDLE_VALUE;
}

Expand Down