-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-37028: Implement asyncio REPL (activated via 'python -m asyncio') #13472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
17e2c05
Implement asyncio REPL (activated via 'python -m asyncio')
1st1 dc35401
Run REPL in a thread; keep asyncio loop always busy in the main thread
1st1 7a973fb
Better handle ^C; filter pointless warnings on exit; edit banner
1st1 3264679
Add NEWS file
1st1 00eb003
nit-fixes
1st1 284a8b1
Cleanup newlines; make input() thread daemon
1st1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
import ast | ||
import asyncio | ||
import code | ||
import concurrent.futures | ||
import inspect | ||
import sys | ||
import threading | ||
import types | ||
import warnings | ||
|
||
from . import futures | ||
|
||
|
||
class AsyncIOInteractiveConsole(code.InteractiveConsole): | ||
|
||
def __init__(self, locals, loop): | ||
super().__init__(locals) | ||
self.compile.compiler.flags |= ast.PyCF_ALLOW_TOP_LEVEL_AWAIT | ||
|
||
self.loop = loop | ||
|
||
def runcode(self, code): | ||
future = concurrent.futures.Future() | ||
|
||
def callback(): | ||
global repl_future | ||
global repl_future_interrupted | ||
|
||
repl_future = None | ||
repl_future_interrupted = False | ||
|
||
func = types.FunctionType(code, self.locals) | ||
try: | ||
coro = func() | ||
except SystemExit: | ||
raise | ||
except KeyboardInterrupt as ex: | ||
repl_future_interrupted = True | ||
future.set_exception(ex) | ||
return | ||
except BaseException as ex: | ||
future.set_exception(ex) | ||
return | ||
|
||
if not inspect.iscoroutine(coro): | ||
future.set_result(coro) | ||
return | ||
|
||
try: | ||
repl_future = self.loop.create_task(coro) | ||
futures._chain_future(repl_future, future) | ||
except BaseException as exc: | ||
future.set_exception(exc) | ||
|
||
loop.call_soon_threadsafe(callback) | ||
|
||
try: | ||
return future.result() | ||
except SystemExit: | ||
raise | ||
except BaseException: | ||
if repl_future_interrupted: | ||
self.write("\nKeyboardInterrupt\n") | ||
else: | ||
self.showtraceback() | ||
|
||
|
||
class REPLThread(threading.Thread): | ||
|
||
def run(self): | ||
try: | ||
banner = ( | ||
f'asyncio REPL {sys.version} on {sys.platform}\n' | ||
f'Use "await" directly instead of "asyncio.run()".\n' | ||
f'Type "help", "copyright", "credits" or "license" ' | ||
f'for more information.\n' | ||
f'{getattr(sys, "ps1", ">>> ")}import asyncio' | ||
) | ||
|
||
console.interact( | ||
banner=banner, | ||
exitmsg='exiting asyncio REPL...') | ||
finally: | ||
warnings.filterwarnings( | ||
'ignore', | ||
message=r'^coroutine .* was never awaited$', | ||
category=RuntimeWarning) | ||
|
||
loop.call_soon_threadsafe(loop.stop) | ||
|
||
|
||
if __name__ == '__main__': | ||
loop = asyncio.new_event_loop() | ||
asyncio.set_event_loop(loop) | ||
|
||
repl_locals = {'asyncio': asyncio} | ||
for key in {'__name__', '__package__', | ||
'__loader__', '__spec__', | ||
'__builtins__', '__file__'}: | ||
repl_locals[key] = locals()[key] | ||
|
||
console = AsyncIOInteractiveConsole(repl_locals, loop) | ||
|
||
repl_future = None | ||
repl_future_interrupted = False | ||
|
||
try: | ||
import readline # NoQA | ||
except ImportError: | ||
pass | ||
|
||
repl_thread = REPLThread() | ||
repl_thread.daemon = True | ||
repl_thread.start() | ||
|
||
while True: | ||
try: | ||
loop.run_forever() | ||
except KeyboardInterrupt: | ||
if repl_future and not repl_future.done(): | ||
repl_future.cancel() | ||
repl_future_interrupted = True | ||
continue | ||
else: | ||
break |
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2019-05-23-18-57-34.bpo-37028.Vse6Pj.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Implement asyncio REPL | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can a note be added to Whats New too? |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.