Skip to content

bpo-34616: Fix code style and unbreak buildbots #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

bpo-34616: Fix code style and unbreak buildbots #13473

merged 1 commit into from
May 21, 2019

Conversation

1st1
Copy link
Member

@1st1 1st1 commented May 21, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 21, 2019
@1st1 1st1 mentioned this pull request May 21, 2019
Merged
@1st1 1st1 added the skip news label May 21, 2019
@1st1 1st1 requested review from asvetlov and ned-deily May 21, 2019 21:15
@1st1
Copy link
Member Author

1st1 commented May 21, 2019

@ned-deily Ned, could you please approve this PR? The buildbots were breaking because the previous commit used the new f'{debug=}' feature, that's not apparently yet supported by test_unparse.py.

@ned-deily ned-deily merged commit eca18aa into python:master May 21, 2019
@ned-deily
Copy link
Member

@1st1, I force pushed it for you. I assume @ambv won't mind :)

@1st1 1st1 deleted the fix34616 branch May 21, 2019 21:23
@1st1
Copy link
Member Author

1st1 commented May 21, 2019

Thank you, Ned!

Yeah, I was thinking about the bright black future while fixing the style :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1st1 @ned-deily @the-knights-who-say-ni @bedevere-bot