Skip to content

Fix typo in docs for socket.CAN_RAW_FD_FRAMES #13635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karlding
Copy link
Contributor

There is an extra "one" in the text description for the constant
socket.CAN_RAW_FD_FRAMES

There is an extra "one" in the text description for the constant
socket.CAN_RAW_FD_FRAMES
@miss-islington
Copy link
Contributor

Thanks @karlding for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @karlding, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1b05aa219041eb1c9dbcb4ec6c1fa5b20f060bf5 3.7

@miss-islington miss-islington self-assigned this May 28, 2019
@Mariatta
Copy link
Member

Thanks @karlding and congrats on your first contribution to CPython 🌮

@karlding
Copy link
Contributor Author

karlding commented May 28, 2019

Thanks @Mariatta! Do I need to do anything to backport this to 3.7 as well?

@Mariatta
Copy link
Member

Yes, please backport to 3.7 branch. Thanks.

karlding added a commit to karlding/cpython that referenced this pull request May 28, 2019
There is an extra "one" in the text description for the constant
socket.CAN_RAW_FD_FRAMES
(cherry picked from commit 1b05aa2)

Co-authored-by: karl ding <[email protected]>
@bedevere-bot
Copy link

GH-13637 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit that referenced this pull request May 28, 2019
)

There is an extra "one" in the text description for the constant
socket.CAN_RAW_FD_FRAMES
(cherry picked from commit 1b05aa2)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
There is an extra "one" in the text description for the constant
socket.CAN_RAW_FD_FRAMES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants