bpo-37120: Add SSLContext.num_tickets (GH-13719) #13719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njsmith
reviewed
Jun 2, 2019
| This attribute is not available unless the ssl module is compiled | ||
| with OpenSSL 1.1.1 or newer. | ||
|
|
||
| .. versionadded:: 3.8 |
There was a problem hiding this comment.
Probably worth noting explicitly that it only affects TLS 1.3 connections, and possibly that it doesn't affect connections that are resumed using a ticket.
There was a problem hiding this comment.
SGTM, the first sentence mentions that it's about TLS 1.3. I added another sentence to explicitly state that the setting does not affect TLS 1.0 to 1.2.
| ctx.num_tickets = None | ||
|
|
||
| ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT) | ||
| self.assertEqual(ctx.num_tickets, 2) |
There was a problem hiding this comment.
It's maybe slightly nicer to make this error out too, I guess?
There was a problem hiding this comment.
You mean getattr access? I'm not sure how much trouble it's going to create.
Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-37120-session-ticket
branch
from
57ba3de to
0d12770
Compare
tiran
changed the title
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Signed-off-by: Christian Heimes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue37120