-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-37412: pythoninfo: add Windows long paths #14434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The code comes from @eryksun, so I added him as a co-author: |
@eryksun: Would you mind to review this change? I tested it manually on my Windows VM:
Maybe it was the Python installer who proposed me to enable this Windows feature, I don't recall. |
|
Oh, there is also a RtlIsLongPathAwareProcessByManifest() function which may be interesting to check: I updated my PR to also call this function. Result on my Windows 10 VM:
Oh, RtlIsLongPathAwareProcessByManifest is not function not available in ntdll on my VM? :-( |
Results on AppVeyor:
Results on Azure Pipeline, win32 and win64 (same values):
|
RtlIsLongPathAwareProcessByManifest may be interesting when I will backport this change to old Python versions. I'm trying to keep the pythoninfo.py code the same in all branches. |
I wouldn't worry about
|
On Windows, test.pythoninfo now checks if support for long paths is enabled using ntdll.RtlAreLongPathsEnabled() function. Co-Authored-By: Eryk Sun <[email protected]>
Ok ok. Anyway, this info can be retrieved indirectly from the Python version. I rebased my PR and squashed commits. @eryksun: Would you mind to review the updated PR? |
I merged my PR. Thanks @eryksun for reviews! |
On Windows, test.pythoninfo now checks if support for long paths is enabled using ntdll.RtlAreLongPathsEnabled() function. Co-Authored-By: Eryk Sun <[email protected]>
On Windows, test.pythoninfo now checks if support for long paths is enabled using ntdll.RtlAreLongPathsEnabled() function. Co-Authored-By: Eryk Sun <[email protected]>
On Windows, test.pythoninfo now checks if support for long paths is
enabled using ntdll.RtlAreLongPathsEnabled() function.
Co-Authored-By: Eryk Sun [email protected]
https://bugs.python.org/issue37412